Bug 73446

Summary: [Qt] Buildfix for generating forwarding headers
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: Tools / TestsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Critical CC: hausmann, ossy, vestbo, webkit.review.bot, zoltan
Priority: P1 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Csaba Osztrogonác
Reported 2011-11-30 07:51:28 PST
I got the following error with WK2 clean build: echo '#include "../WebCore/generated/HTMLNames.h"' > /storage/WebKit/WebKitBuild/Release/Source/include/WebCore/HTMLNames.h echo '#include "../WebCore/generated/JSCSSStyleDeclaration.h"' > /storage/WebKit/WebKitBuild/Release/Source/include/WebCore/JSCSSStyleDeclara tion.h /bin/sh: cannot create /storage/WebKit/WebKitBuild/Release/Source/include/WebCore/HTMLNames.h: Directory nonexistent make[3]: *** [/storage/WebKit/WebKitBuild/Release/Source/include/WebCore/HTMLNames.h] Error 2 make[3]: *** Waiting for unfinished jobs.... /bin/sh: cannot create /storage/WebKit/WebKitBuild/Release/Source/include/WebCore/JSCSSStyleDeclaration.h: Directory nonexistent make[3]: *** [/storage/WebKit/WebKitBuild/Release/Source/include/WebCore/JSCSSStyleDeclaration.h] Error 2 ------------------------- The problem is that nobody creates the directory previously. Fix is coming soon.
Attachments
Patch (1.53 KB, patch)
2011-11-30 07:56 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2011-11-30 07:56:10 PST
Created attachment 117194 [details] Patch
Csaba Osztrogonác
Comment 2 2011-11-30 08:32:08 PST
Unfortunately it won't work on Windows :-/ Because QMAKE_MKDIR == mkdir for windows cmd, but it returns with error if the directory exists. I thought I should use QMAKE_CHK_DIR_EXISTS, but it is absolutely incompatible on Windows and on Linux: win: QMAKE_CHK_DIR_EXISTS = if not exist linux: QMAKE_CHK_DIR_EXISTS = test -d
WebKit Review Bot
Comment 3 2011-11-30 19:10:25 PST
Comment on attachment 117194 [details] Patch Clearing flags on attachment: 117194 Committed r101589: <http://trac.webkit.org/changeset/101589>
WebKit Review Bot
Comment 4 2011-11-30 19:10:30 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.