Bug 73442

Summary: Web Inspector: query backend for capabilities explicitly.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, bweinstein, japhet, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
[Patch] rebaselined none

Pavel Feldman
Reported 2011-11-30 06:54:57 PST
This change removes the hardcoded Capabilities values in favor of explicit query commands issued against the server. I'll remove the Meta agent in subsequent change.
Attachments
Patch (39.29 KB, patch)
2011-11-30 07:10 PST, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
[Patch] rebaselined (41.00 KB, patch)
2011-12-01 00:49 PST, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-11-30 07:10:37 PST
Created attachment 117187 [details] Patch
Yury Semikhatsky
Comment 2 2011-11-30 08:06:57 PST
Comment on attachment 117187 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117187&action=review > Source/WebCore/bindings/js/ScriptDebugServer.h:87 > + bool causesRecompilation() { return true; } recompilesSourcesOnStart > Source/WebCore/bindings/js/ScriptProfiler.h:58 > + static bool causesRecompilation() { return true; } Same here, the name is confusing. > Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js:157 > +InspectorFrontendHost.isStub = true; This should go in the InspectorFrontendHostStub constructor or even prototype.
Pavel Feldman
Comment 3 2011-12-01 00:49:12 PST
Created attachment 117373 [details] [Patch] rebaselined
Pavel Feldman
Comment 4 2011-12-01 03:33:28 PST
Committed r101651: <http://trac.webkit.org/changeset/101651>
Note You need to log in before you can comment on or make changes to this bug.