Summary: | [v8] Expose the "filter" property in V8CSSStyleDeclaration | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexander Pavlov (apavlov) <apavlov> | ||||||
Component: | WebCore Misc. | Assignee: | Alexander Pavlov (apavlov) <apavlov> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, antonm, darin, dglazkov, japhet, peter, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Alexander Pavlov (apavlov)
2011-11-30 03:55:54 PST
Created attachment 117362 [details]
Patch
Comment on attachment 117362 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117362&action=review > Source/WebCore/ChangeLog:9 > + The "filter" CSS property used to be masked to be compliant with JSC, but JSC has supported > + this property for quite a while. Is there a test? (In reply to comment #2) > (From update of attachment 117362 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=117362&action=review > > > Source/WebCore/ChangeLog:9 > > + The "filter" CSS property used to be masked to be compliant with JSC, but JSC has supported > > + this property for quite a while. > > Is there a test? This fix goes in parallel with bug 23946 fix (as suggested by Darin Adler), and until that bug is fixed, we can only inspect the value of the property directly (currently it is not enumerable,) as opposed to using the "in" operator, which can be done in a test modified to accompany the bug 23946 fix. Which approach seems preferred to you? Created attachment 118791 [details]
[PATCH] A test to make sure the "filter" property is enumerated
The latest patch now has a test. Reviewers? Comment on attachment 118791 [details] [PATCH] A test to make sure the "filter" property is enumerated Clearing flags on attachment: 118791 Committed r102913: <http://trac.webkit.org/changeset/102913> All reviewed patches have been landed. Closing bug. |