Bug 73403

Summary: Make FrameView use TemporarilyChange in a few places.
Product: WebKit Reporter: David Levin <levin>
Component: Layout and RenderingAssignee: David Levin <levin>
Status: RESOLVED FIXED    
Severity: Normal CC: dimich
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 73035    
Attachments:
Description Flags
Patch dimich: review+

David Levin
Reported 2011-11-29 23:29:14 PST
See summary.
Attachments
Patch (14.27 KB, patch)
2011-11-29 23:34 PST, David Levin 		dimich: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Levin
Comment 1 2011-11-29 23:34:02 PST
Created attachment 117131 [details] Patch
Alexey Proskuryakov
Comment 2 2011-11-30 11:42:19 PST
Comment on attachment 117131 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117131&action=review > Source/WebCore/ChangeLog:12 > + (WebCore::FrameView::forceLayoutParentViewIfNeeded): Since this function isn't > + re-entrant, TemporarilyChange does the same thing but in a more robust manner Should we add an ASSERT to ensure that it's not re-entrant?
Dmitry Titov
Comment 3 2011-11-30 12:00:09 PST
Comment on attachment 117131 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117131&action=review r=me > Source/WebCore/ChangeLog:19 > + and TemporarilyChange behave like they did before. A few variables were move d before move d->moved
Dmitry Titov
Comment 4 2011-11-30 12:01:06 PST
oops, didn't see the Alexey's comment. It makes sense to me as well.
David Levin
Comment 5 2011-11-30 13:38:54 PST
Committed as http://trac.webkit.org/changeset/101549 Added the assert, fixed the changelog, and added a minor comment about the scoping as discussed.
Note You need to log in before you can comment on or make changes to this bug.