Bug 73400

Summary: Add move semantics to WKRetainPtr
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch andersca: review+

Sam Weinig
Reported 2011-11-29 22:20:12 PST
Add move semantics to WKRetainPtr
Attachments
Patch (2.69 KB, patch)
2011-11-29 22:25 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (2.89 KB, patch)
2011-11-29 22:26 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (2.92 KB, patch)
2011-11-30 10:09 PST, Sam Weinig 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2011-11-29 22:25:31 PST
Created attachment 117126 [details] Patch
Sam Weinig
Comment 2 2011-11-29 22:26:49 PST
Created attachment 117127 [details] Patch
WebKit Review Bot
Comment 3 2011-11-29 22:28:51 PST
Attachment 117126 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/UIProcess/API/cpp/WKRetainPtr.h:119: Missing spaces around && [whitespace/operators] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Review Bot
Comment 4 2011-11-29 22:33:39 PST
Attachment 117127 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/UIProcess/API/cpp/WKRetainPtr.h:119: Missing spaces around && [whitespace/operators] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 5 2011-11-30 10:09:13 PST
Created attachment 117210 [details] Patch
WebKit Review Bot
Comment 6 2011-11-30 10:11:09 PST
Attachment 117210 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/UIProcess/API/cpp/WKRetainPtr.h:119: Missing spaces around && [whitespace/operators] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 7 2011-11-30 10:26:31 PST
Committed r101529: <http://trac.webkit.org/changeset/101529>
Note You need to log in before you can comment on or make changes to this bug.