Summary: | [regions] Need to verify the correctness of Win/Linux on overflow break tests | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tony Chang <tony> | ||||
Component: | Layout and Rendering | Assignee: | Mihnea Ovidenie <mihnea> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Tony Chang
2011-11-29 10:18:16 PST
The difference in tests comes from the usage of Times font-family (default in font-family in browsers). Tests are not wrong but we can improve them by using a monospace font, that will reduce the differences between platforms when using text-align: justify. I also tested with a linux gtk build of webkit and when using a monospace font, the rendering is pretty close. I will upload a patch with the modified tests. Created attachment 117793 [details]
Patch
Comment on attachment 117793 [details]
Patch
Thanks!
BTW, you could possibly use Ahem to make it even more similar across platforms. Comment on attachment 117793 [details] Patch Clearing flags on attachment: 117793 Committed r102015: <http://trac.webkit.org/changeset/102015> All reviewed patches have been landed. Closing bug. |