Bug 73307

Summary: Implement the [NamedConstructor] IDL in CodeGeneratorJS.pm
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: DOMAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dominicc, japhet, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
abarth: review+, webkit.review.bot: commit-queue-
rebased patch for commit none

Kentaro Hara
Reported 2011-11-29 04:19:54 PST
CodeGeneratorV8.pm has already implemented the [NamedConstructor] IDL. CodeGeneratorJS.pm should also implement it. The spec: http://www.w3.org/TR/WebIDL/#NamedConstructor
Attachments
Patch (19.99 KB, patch)
2011-11-29 04:26 PST, Kentaro Hara 		abarth: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
rebased patch for commit (20.59 KB, patch)
2011-11-30 00:23 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2011-11-29 04:26:11 PST
Created attachment 116945 [details] Patch
Adam Barth
Comment 2 2011-11-29 09:07:39 PST
It's not 100% clear to me why the notion of a named constructor is tied up with the notion of the constructor taking a Document as an argument. We've used CallWith=ScriptExecutionContext for that elsewhere. That said, this seems fine if all our uses take a Document.
WebKit Review Bot
Comment 3 2011-11-30 00:09:18 PST
Comment on attachment 116945 [details] Patch Rejecting attachment 116945 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: 11 lines). Hunk #9 succeeded at 3558 (offset 111 lines). Hunk #10 succeeded at 3572 (offset 111 lines). 1 out of 10 hunks FAILED -- saving rejects to file Source/WebCore/bindings/scripts/CodeGeneratorJS.pm.rej patching file Source/WebCore/bindings/scripts/test/JS/JSTestNamedConstructor.cpp patching file Source/WebCore/bindings/scripts/test/JS/JSTestNamedConstructor.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/10697090
Kentaro Hara
Comment 4 2011-11-30 00:23:04 PST
Created attachment 117135 [details] rebased patch for commit
WebKit Review Bot
Comment 5 2011-11-30 06:56:06 PST
Comment on attachment 117135 [details] rebased patch for commit Clearing flags on attachment: 117135 Committed r101508: <http://trac.webkit.org/changeset/101508>
Note You need to log in before you can comment on or make changes to this bug.