Bug 73296 – [GTK] generate-gtkdoc should respect build type

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Martin Robinson]

Right now generate-gtkdoc just tries to guess what your build type is, with a preference toward a release build. It shoud be smarter about what type of build you are using by means of a command-line parameter.

[Martin Robinson]

Created attachment 116925 [details]
Patch

[Philippe Normand]

Comment on attachment 116925 [details]
Patch

LGTM

[WebKit Review Bot]

Comment on attachment 116925 [details]
Patch

Rejecting attachment 116925 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Philippe Normand', u'-..." exit_code: 1

Parsed 3 diffs from patch file(s).
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/Scripts/webkitdirs.pm
patching file Tools/gtk/common.py
Hunk #1 FAILED at 40.
1 out of 1 hunk FAILED -- saving rejects to file Tools/gtk/common.py.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Philippe Normand', u'-..." exit_code: 1

Full output: http://queues.webkit.org/results/10704207

[Martin Robinson]

Committed r101820: <http://trac.webkit.org/changeset/101820>