Bug 73267

Summary: opacity should flatten when combined with transform-style: preserve-3d
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: CSSAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, dino, eoconnor, mrobinson, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://ikilote.net/Programmation/CSS/Test/transform-style.htm
Bug Depends on:    
Bug Blocks: 218369    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Comment 1 Martin Robinson 2021-10-27 08:19:01 PDT 
Created attachment 442592 [details]
Patch
Comment 2 Simon Fraser (smfr) 2021-10-27 09:50:23 PDT 
Comment on attachment 442592 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442592&action=review

> Source/WebCore/style/StyleAdjuster.cpp:502
>      // FIXME: when dropping the -webkit prefix on transform-style, we should also have opacity < 1 cause flattening.

You should remove this comment.
Comment 3 Martin Robinson 2021-10-27 11:52:44 PDT 
Created attachment 442618 [details]
Patch
Comment 4 Simon Fraser (smfr) 2021-10-27 12:07:21 PDT 
Comment on attachment 442618 [details]
Patch

I'm concerned about the compat risk of this change, but we can try it.
Comment 5 Martin Robinson 2021-10-28 04:00:31 PDT 
Created attachment 442690 [details]
Patch
Comment 6 Martin Robinson 2021-10-28 04:12:54 PDT 
Created attachment 442691 [details]
Patch
Comment 7 EWS 2021-10-29 02:13:32 PDT 
Committed r285021 (243665@main): <https://commits.webkit.org/243665@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442691 [details].
Comment 8 Radar WebKit Bug Importer 2021-10-29 02:14:28 PDT 
<rdar://problem/84801136>