Bug 73248

Summary: Move typed array implementations into wtf
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dslomov, japhet, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch sam: review+

Oliver Hunt
Reported 2011-11-28 14:11:19 PST
Move typed array implementations into wtf
Attachments
Patch (230.42 KB, patch)
2011-11-28 14:13 PST, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Patch (245.14 KB, patch)
2011-11-28 14:53 PST, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Patch (248.79 KB, patch)
2011-11-28 15:10 PST, Oliver Hunt 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2011-11-28 14:13:58 PST
Created attachment 116817 [details] Patch
Oliver Hunt
Comment 2 2011-11-28 14:28:20 PST
Just waiting for build bots to churn -- working on v8 codegen at the moment
Oliver Hunt
Comment 3 2011-11-28 14:53:42 PST
Created attachment 116828 [details] Patch
WebKit Review Bot
Comment 4 2011-11-28 14:58:28 PST
Attachment 116828 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/WebCore/bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp:62: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/WebCore/bindings/scripts/test/CPP/WebDOMFloat64Array.h:41: The parameter name "array" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 88 files If any of these errors are false positives, please file a bug against check-webkit-style.
Oliver Hunt
Comment 5 2011-11-28 15:10:19 PST
Created attachment 116835 [details] Patch
Dmitry Lomov
Comment 6 2011-11-28 15:19:53 PST
This looks good to me.
WebKit Review Bot
Comment 7 2011-11-28 15:20:16 PST
Attachment 116835 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/WebCore/bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp:62: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/WebCore/bindings/scripts/test/CPP/WebDOMFloat64Array.h:41: The parameter name "array" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 89 files If any of these errors are false positives, please file a bug against check-webkit-style.
Oliver Hunt
Comment 8 2011-11-28 15:42:23 PST
Committed r101295: <http://trac.webkit.org/changeset/101295>
Note You need to log in before you can comment on or make changes to this bug.