Bug 73199

Summary: CSSStyleDeclaration: Remove ability to have style sheet as parent.
Product: WebKit Reporter: Andreas Kling <kling>
Component: CSSAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: macpherson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch koivisto: review+

Description Andreas Kling 2011-11-28 03:11:17 PST 
In the CSSOM, style declarations only ever have rules as parents. Reflecting this in WebKit would reduce the complexity of CSSStyleDeclaration.
Comment 1 Andreas Kling 2011-11-28 03:25:33 PST 
Created attachment 116723 [details]
Patch
Comment 2 Antti Koivisto 2011-11-28 03:33:21 PST 
Comment on attachment 116723 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=116723&action=review

r=me, with some comments

> Source/WebCore/svg/SVGFontFaceElement.cpp:51
> +class FontFaceStyleDeclaration : public CSSElementStyleDeclaration {
> +public:
> +    FontFaceStyleDeclaration(SVGFontFaceElement* element)

To stick with the coding style, you should have create() for construction.

You should add a comment here explaining why this class is needed and how we can eventually get rid of it.
Comment 3 Andreas Kling 2011-11-28 04:50:48 PST 
Committed r101250: <http://trac.webkit.org/changeset/101250>