Bug 73196

Summary: Upstream platform/network/blackberry/AuthenticationChallenge.h
Product: WebKit Reporter: Leo Yang <leo.yang>
Component: New BugsAssignee: Leo Yang <leo.yang>
Status: RESOLVED FIXED    
Severity: Normal CC: charles.wei, dbates, rwlbuis, staikos, tonikitoo, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 73144    
Attachments:
Description Flags
Patch
zimmermann: review+, dbates: commit-queue-
Patch v2 dbates: review+

Description Leo Yang 2011-11-28 01:30:08 PST
This is to upstream the BlackBerry porting of AuthenticationChallenge.h.
Comment 1 Leo Yang 2011-11-28 01:59:21 PST
Created attachment 116713 [details]
Patch
Comment 2 Nikolas Zimmermann 2011-11-28 06:55:04 PST
Comment on attachment 116713 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=116713&action=review

r=me.

> Source/WebCore/platform/network/blackberry/AuthenticationChallenge.h:43
> +    // If attached credentials stored in CredentialStorage.

"Describes if the attached credentials are stored in CredentialStorage."
We should use full sentences.
Comment 3 Daniel Bates 2011-11-28 08:58:27 PST
Comment on attachment 116713 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=116713&action=review

> Source/WebCore/ChangeLog:10
> +        This is the BlackBerry implementation of WebCore::AuthenticationChallenge.
> +
> +        Other contributors:
> +        Jason C Chan <jasochan@rim.com>
> +        Jakob Petsovits <jpetsovits@rim.com>

This should be moved so that it comes after the Reviewed by line.

> Source/WebCore/platform/network/blackberry/AuthenticationChallenge.h:47
> +}

This file is short. That being said, we usually write an inline comment here, // namespace WebCore, to demarcate the end of the WebCore namespace.

> Source/WebCore/platform/network/blackberry/AuthenticationChallenge.h:49
> +#endif

This file is short. That being said, we usually write an inline comment here, // AuthenticationChallenge_h, to demarcate the end of the #ifndef.
Comment 4 Leo Yang 2011-11-28 17:49:41 PST
Created attachment 116861 [details]
Patch v2

Not set commit-queue? because cq seems slow and the patch will bring no regression. I'll commit it manually.
Comment 5 Leo Yang 2011-11-28 18:18:20 PST
Committed r101312: <http://trac.webkit.org/changeset/101312>