Bug 73196 – Upstream platform/network/blackberry/AuthenticationChallenge.h

• Component: New Bugs
• Status: RESOLVED FIXED

[Leo Yang]

This is to upstream the BlackBerry porting of AuthenticationChallenge.h.

[Leo Yang]

Created attachment 116713 [details]
Patch

[Nikolas Zimmermann]

Comment on attachment 116713 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=116713&action=review

r=me.

> Source/WebCore/platform/network/blackberry/AuthenticationChallenge.h:43
> +    // If attached credentials stored in CredentialStorage.

"Describes if the attached credentials are stored in CredentialStorage."
We should use full sentences.

[Daniel Bates]

Comment on attachment 116713 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=116713&action=review

> Source/WebCore/ChangeLog:10
> +        This is the BlackBerry implementation of WebCore::AuthenticationChallenge.
> +
> +        Other contributors:
> +        Jason C Chan <[e-mail]>
> +        Jakob Petsovits <[e-mail]>

This should be moved so that it comes after the Reviewed by line.

> Source/WebCore/platform/network/blackberry/AuthenticationChallenge.h:47
> +}

This file is short. That being said, we usually write an inline comment here, // namespace WebCore, to demarcate the end of the WebCore namespace.

> Source/WebCore/platform/network/blackberry/AuthenticationChallenge.h:49
> +#endif

This file is short. That being said, we usually write an inline comment here, // AuthenticationChallenge_h, to demarcate the end of the #ifndef.

[Leo Yang]

Created attachment 116861 [details]
Patch v2

Not set commit-queue? because cq seems slow and the patch will bring no regression. I'll commit it manually.

[Leo Yang]

Committed r101312: <http://trac.webkit.org/changeset/101312>