Bug 73192

Summary: <style scoped>: implement scoped selector matching
Product: WebKit Reporter: Roland Steiner <rolandsteiner>
Component: CSSAssignee: Roland Steiner <rolandsteiner>
Status: RESOLVED FIXED    
Severity: Enhancement CC: dglazkov, dominicc, koivisto, macpherson, menard, morrita, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 73190, 77410, 77525, 77528    
Bug Blocks: 49142, 67720    
Attachments:
Description Flags
patch (requires 67790, 73190), with flag
none
patch, updated none

Description Roland Steiner 2011-11-27 23:35:03 PST 
Restrict selector matching to only match up to (and including) the scoping element, but not its ancestors.
Comment 1 Roland Steiner 2011-11-27 23:44:33 PST 
Note: Will wait with uploading the patch until 73190 settles.
Comment 2 Roland Steiner 2011-12-09 00:19:51 PST 
Created attachment 118541 [details]
patch (requires 67790, 73190), with flag
Comment 3 Roland Steiner 2012-01-04 21:18:59 PST 
New Year request for review! :)
Comment 4 Roland Steiner 2012-02-01 01:05:16 PST 
Created attachment 124899 [details]
patch, updated

Updated patch after landing basic <style scoped> implementation. Remarks: I'm storing the scope to use in member variables in order to reduce the amount of paramter passing and #ifdef-ing. I'm not sure if I should go further and do this for fastCheckSingleSelector as well (although this would require making that template function a class member) or, conversely, whether it's a good idea in the first place.
Comment 5 Roland Steiner 2012-02-01 01:36:15 PST 
Splitting this up into several patches as discussed with Antti on IRC.