Bug 73160

Summary: [Refactoring] In preprocessor.pm, remove double quotations from $defines
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: DOMAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, alex, japhet, mrobinson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
rebased patch for commit none

Kentaro Hara
Reported 2011-11-26 12:44:50 PST
In preprocessor.pm, we need to extract gcc macros from $defines. $defines can contain unnecessary double quotations. For example, if $defines is ' "A=1" "B=1" C=1 "" D ', then it should be converted into four macros, -DA=1, -DB=1, -DC=1 and -DD. This bug refactors the above logic in preprocessor.pm.
Attachments
Patch (2.17 KB, patch)
2011-11-26 12:50 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Patch (3.21 KB, patch)
2011-11-26 13:03 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
rebased patch for commit (3.19 KB, patch)
2011-11-29 21:52 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2011-11-26 12:50:54 PST
Created attachment 116662 [details] Patch
Kentaro Hara
Comment 2 2011-11-26 13:03:17 PST
Created attachment 116663 [details] Patch
Kentaro Hara
Comment 3 2011-11-26 14:42:46 PST
mrobinson: Does this change look OK? After receiving your 'yes', I'd like to commit it.
WebKit Review Bot
Comment 4 2011-11-29 21:21:52 PST
Comment on attachment 116663 [details] Patch Rejecting attachment 116663 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: rce/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/bindings/scripts/generate-bindings.pl Hunk #1 succeeded at 67 with fuzz 1 (offset 3 lines). Hunk #2 FAILED at 71. 1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/bindings/scripts/generate-bindings.pl.rej patching file Source/WebCore/bindings/scripts/preprocessor.pm Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/10712049
Kentaro Hara
Comment 5 2011-11-29 21:52:09 PST
Created attachment 117119 [details] rebased patch for commit
WebKit Review Bot
Comment 6 2011-11-30 06:33:59 PST
Comment on attachment 117119 [details] rebased patch for commit Clearing flags on attachment: 117119 Committed r101506: <http://trac.webkit.org/changeset/101506>
Note You need to log in before you can comment on or make changes to this bug.