Summary: | Clean up code in WK2/ChromeClientClient related to viewport handling | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kenneth Rohde Christiansen <kenneth> | ||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | hausmann, zalan | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Kenneth Rohde Christiansen
2011-11-25 05:21:25 PST
Created attachment 116603 [details]
Patch
lgtm. a small observation. + This method is only called for the main frame, so the main frame + check has been removed. It looks to me a null check rather than a mainframe check. However, m_page->useFixedLayout() does eliminate the need for the null check, so the code is correct. Comment on attachment 116603 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=116603&action=review r=me but I'll let you decide on cq+ based on the #ifdef comment > Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp:448 > +#if USE(TILED_BACKING_STORE) > + if (m_page->useFixedLayout()) > + m_page->resizeToContentsIfNeeded(); > +#endif For WK2 it does seem a bit strange to have USE(TILED_BACKING_STORE) for this. Do we actually need the #ifdef? Comment on attachment 116603 [details] Patch landed in r101167 |