Bug 73123

Summary: Web Inspector: unflake timeline-network tests
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch yurys: review+

Description Pavel Feldman 2011-11-25 04:09:42 PST
We should capture stack only when it makes sense. Otherwise loading from cache results in different data sets (stacks) than regular load.
Comment 1 Pavel Feldman 2011-11-25 04:22:15 PST
Created attachment 116598 [details]
Patch
Comment 2 Yury Semikhatsky 2011-11-25 06:25:44 PST
Comment on attachment 116598 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=116598&action=review

> Source/WebCore/inspector/InspectorTimelineAgent.cpp:178
>      pushCurrentRecord(TimelineRecordFactory::createEventDispatchData(event),

style: put this code on a single line?
Comment 3 Pavel Feldman 2011-11-25 06:32:38 PST
Committed r101170: <http://trac.webkit.org/changeset/101170>