Bug 73109 – [Refactoring] Remove WebCore.gyp/scripts/rule_binding.py

• Component: DOM
• Status: RESOLVED FIXED

[Kentaro Hara]

rule_binding.py is used by WebCore.gyp only. rule_binding.py is just a wrapper of generate-bindings.pl and thus we can remove it.

[Kentaro Hara]

Created attachment 116560 [details]
Patch

[Collabora GTK+ EWS bot]

Comment on attachment 116560 [details]
Patch

Attachment 116560 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/10640147

[Adam Barth]

Comment on attachment 116560 [details]
Patch

Looks like you might have some trouble with GTK.  Sometimes we have these wrappers to deal with windowisms.  I don't see any in this file though.

[Kentaro Hara]

(In reply to comment #3)
> (From update of attachment 116560 [details])
> Looks like you might have some trouble with GTK.  Sometimes we have these wrappers to deal with windowisms.  I don't see any in this file though.

I am investigating it... This is the reason that the WIP patch for bug 72138 is failing on gtk. Thanks.

[Kentaro Hara]

Created attachment 116567 [details]
see if gtk looks happy

[Kentaro Hara]

Created attachment 116573 [details]
rebased patch for commit

[WebKit Review Bot]

Comment on attachment 116573 [details]
rebased patch for commit

Clearing flags on attachment: 116573

Committed r101157: <http://trac.webkit.org/changeset/101157>

[Kentaro Hara]

FYI: The reason for the gtk failure was as follows:

Before: map { $_ =~ s/^\"|\"$//g; "-D$_" } split(' ', $defines)
(In this case, "-D$_" can be "-D", which leads to an unexpected command-line flag.)

After: map { $_ =~ s/^\"|\"$//g; "-D$_" if $_ } split(' ', $defines)