Bug 73105 – In run-bindings-tests, replace subprocess.call() with subprocess.Popen()

• Component: DOM
• Status: RESOLVED FIXED

[Kentaro Hara]

Currently, the stdout and stderr of the child processes of run-bindings-tests are mixed (or even gone away) with the stdout and stderr of run-bindings-tests itself. This is the problem of subprocess.call(), which does not synchronize the stdout and stderr between a parent process and a child process. We should replace subprocess.call() with subprocess.Popen() and synchronize the stdout and stderr between them. This makes output messages of run-bindings-tests more readable.

[Kentaro Hara]

Created attachment 116556 [details]
Patch

[WebKit Review Bot]

Comment on attachment 116556 [details]
Patch

Clearing flags on attachment: 116556

Committed r101150: <http://trac.webkit.org/changeset/101150>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Eric Seidel (no email)]

Comment on attachment 116556 [details]
Patch

As this script grows it should probably move to integrate with the rest of webkitpy (move it's main function onto a new class stored in webkitpy/bindings/main.py, etc.) and use Executive instead of Popen directly for easier mocking/testing.

[Kentaro Hara]

(In reply to comment #4)
> (From update of attachment 116556 [details])
> As this script grows it should probably move to integrate with the rest of webkitpy (move it's main function onto a new class stored in webkitpy/bindings/main.py, etc.) and use Executive instead of Popen directly for easier mocking/testing.

OK, I will move run_bindings_tests to webkitpy/ in bug 73619 and then replace Popen with Executive in another bug.

[Eric Seidel (no email)]

Thanks!