Bug 73096

Summary: [Qt][WK2] Refactor GestureRecognizers to use QtWebPageEventHandler
Product: WebKit Reporter: Jesus Sanchez-Palencia <jesus>
Component: WebKit QtAssignee: Jesus Sanchez-Palencia <jesus>
Status: RESOLVED FIXED    
Severity: Normal CC: kenneth
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 73089    
Bug Blocks:    
Attachments:
Description Flags
Patch kenneth: review+

Jesus Sanchez-Palencia
Reported 2011-11-24 13:40:44 PST
We can move all the interaction engine usage to QtWebPageEventHandler and make all GestureRecognizers (Tap, Pinch and Pan) use it directly.
Attachments
Patch (17.04 KB, patch)
2011-11-24 13:49 PST, Jesus Sanchez-Palencia 		kenneth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jesus Sanchez-Palencia
Comment 1 2011-11-24 13:49:16 PST
Created attachment 116547 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2011-11-25 03:59:58 PST
Comment on attachment 116547 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=116547&action=review > Source/WebKit2/UIProcess/qt/QtPanGestureRecognizer.cpp:53 > + m_eventHandler->interactionEngine()->panGestureCancelled(); Why not make an private: inline QtViewportInteractionEngine* interactionEngine() ? It could be in the class they all inherit from
Jesus Sanchez-Palencia
Comment 3 2011-11-25 11:58:00 PST
Committed r101179: <http://trac.webkit.org/changeset/101179>
Note You need to log in before you can comment on or make changes to this bug.