Bug 73081

Summary: [Chromium] Web Inspector: remove legacy debugger support
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, bweinstein, fishd, japhet, joepeck, keishi, loislo, peter.rybin, pfeldman, pmuellr, rik, timothy, tkent, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch pfeldman: review+

Description Yury Semikhatsky 2011-11-24 07:22:11 PST 
New web inspector protocol should provide all necessary debugging capabilities.
Comment 1 Yury Semikhatsky 2011-11-24 07:31:46 PST 
Created attachment 116509 [details]
Patch
Comment 2 Yury Semikhatsky 2011-11-24 07:33:52 PST 
Created attachment 116510 [details]
Patch
Comment 3 WebKit Review Bot 2011-11-24 07:33:57 PST 
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Comment 4 Pavel Feldman 2011-11-24 07:54:12 PST 
Comment on attachment 116510 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=116510&action=review

> Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp:184
> +    ASSERT(m_hostId > 0);

Where did this come from?
Comment 5 Yury Semikhatsky 2011-11-24 09:00:49 PST 
Comment on attachment 116510 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=116510&action=review

>> Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp:184
>> +    ASSERT(m_hostId > 0);
> 
> Where did this come from?

It was in DebuggerAgentManager::setHostId
Comment 6 Yury Semikhatsky 2011-11-24 10:45:25 PST 
Created attachment 116522 [details]
Patch
Comment 7 Yury Semikhatsky 2011-11-25 01:29:50 PST 
Committed r101156: <http://trac.webkit.org/changeset/101156>