Bug 73081

Summary: [Chromium] Web Inspector: remove legacy debugger support
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, bweinstein, fishd, japhet, joepeck, keishi, loislo, peter.rybin, pfeldman, pmuellr, rik, timothy, tkent, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch pfeldman: review+

Yury Semikhatsky
Reported 2011-11-24 07:22:11 PST
New web inspector protocol should provide all necessary debugging capabilities.
Attachments
Patch (32.12 KB, patch)
2011-11-24 07:31 PST, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Patch (32.21 KB, patch)
2011-11-24 07:33 PST, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Patch (36.55 KB, patch)
2011-11-24 10:45 PST, Yury Semikhatsky 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2011-11-24 07:31:46 PST
Created attachment 116509 [details] Patch
Yury Semikhatsky
Comment 2 2011-11-24 07:33:52 PST
Created attachment 116510 [details] Patch
WebKit Review Bot
Comment 3 2011-11-24 07:33:57 PST
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Pavel Feldman
Comment 4 2011-11-24 07:54:12 PST
Comment on attachment 116510 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=116510&action=review > Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp:184 > + ASSERT(m_hostId > 0); Where did this come from?
Yury Semikhatsky
Comment 5 2011-11-24 09:00:49 PST
Comment on attachment 116510 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=116510&action=review >> Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp:184 >> + ASSERT(m_hostId > 0); > > Where did this come from? It was in DebuggerAgentManager::setHostId
Yury Semikhatsky
Comment 6 2011-11-24 10:45:25 PST
Created attachment 116522 [details] Patch
Yury Semikhatsky
Comment 7 2011-11-25 01:29:50 PST
Committed r101156: <http://trac.webkit.org/changeset/101156>
Note You need to log in before you can comment on or make changes to this bug.