Bug 73018

Summary: [EFL] Remove the ewk_protocol_handler-related code
Product: WebKit Reporter: Raphael Kubo da Costa (:rakuco) <rakuco>
Component: WebKit EFLAssignee: Raphael Kubo da Costa (:rakuco) <rakuco>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, mrobinson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch none

Raphael Kubo da Costa (:rakuco)
Reported 2011-11-23 06:18:00 PST
This functionality has been broken since r99364, which stopped setting the "webkit-resource" property needed by ewk_protocol_handler_soup.cpp. After giving it some thought, it looks clear that this code should not be in ewk at all: it is very backend-specific (even in the function signatures it expects), and it only allows callers to register schemes once and provide a single handler to all of them, which does not make much sense.
Attachments
Proposed patch (22.68 KB, patch)
2011-12-01 13:06 PST, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Raphael Kubo da Costa (:rakuco)
Comment 1 2011-12-01 13:06:21 PST
Created attachment 117468 [details] Proposed patch
Raphael Kubo da Costa (:rakuco)
Comment 2 2011-12-01 13:07:55 PST
CC'ing mrobinson; this should fix the issue discussed on IRC a few weeks ago in which r99364 removed our custom handler code in ewk.
WebKit Review Bot
Comment 3 2011-12-01 17:32:48 PST
Comment on attachment 117468 [details] Proposed patch Clearing flags on attachment: 117468 Committed r101726: <http://trac.webkit.org/changeset/101726>
WebKit Review Bot
Comment 4 2011-12-01 17:32:52 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.