Bug 73014

Summary:

[GStreamer] improper usage of gst_object_ref_sink

Product:

WebKit

Reporter:

Philippe Normand <pnormand>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

69835

Attachments:

Description	Flags
proposed patch	mrobinson: review+

Philippe Normand

Reported 2011-11-23 03:46:21 PST

To take ownership of GstObjects we should call gst_object_ref and gst_object_sink. Additionally we should ensure adoptGRef is used only on non-floating GstObjects.

Attachments
proposed patch (3.32 KB, patch) 2011-11-23 03:51 PST, Philippe Normand	mrobinson: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Philippe Normand

Comment 1 2011-11-23 03:51:49 PST

Created attachment 116338 [details] proposed patch

Martin Robinson

Comment 2 2011-11-23 03:59:18 PST

Comment on attachment 116338 [details] proposed patch Great!

Philippe Normand

Comment 3 2011-11-23 07:33:47 PST

Committed r101082: <http://trac.webkit.org/changeset/101082>

Note You need to log in before you can comment on or make changes to this bug.