Bug 73014 - [GStreamer] improper usage of gst_object_ref_sink
Summary: [GStreamer] improper usage of gst_object_ref_sink
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 69835
  Show dependency treegraph
Reported: 2011-11-23 03:46 PST by Philippe Normand
Modified: 2011-11-23 07:33 PST (History)
0 users

See Also:

proposed patch (3.32 KB, patch)
2011-11-23 03:51 PST, Philippe Normand
mrobinson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2011-11-23 03:46:21 PST
To take ownership of GstObjects we should call gst_object_ref and gst_object_sink. Additionally we should ensure adoptGRef is used only on non-floating GstObjects.
Comment 1 Philippe Normand 2011-11-23 03:51:49 PST
Created attachment 116338 [details]
proposed patch
Comment 2 Martin Robinson 2011-11-23 03:59:18 PST
Comment on attachment 116338 [details]
proposed patch

Comment 3 Philippe Normand 2011-11-23 07:33:47 PST
Committed r101082: <http://trac.webkit.org/changeset/101082>