Bug 72998

Summary: WebIDL: Add support for static for JSC and V8
Product: WebKit Reporter: Erik Arvidsson <arv>
Component: DOMAssignee: Erik Arvidsson <arv>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, code.vineet, dominicc, japhet, kaustubh.ra, ojan, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://www.w3.org/TR/WebIDL/#idl-static-operations
Bug Depends on: 73342    
Bug Blocks: 71968, 73365    
Attachments:
Description Flags
Patch
none
Patch abarth: review+

Erik Arvidsson
Reported 2011-11-22 18:19:38 PST
http://www.w3.org/TR/WebIDL/#idl-static-operations We need to add support for static to be able to correctly implement the URL object. Our implementation of the URL object is flawed. window.webkitURL returns an instance of DOMURL when it should return a URL constructor. http://www.w3.org/TR/FileAPI/#URL-object
Attachments
Patch (19.19 KB, patch)
2011-11-29 14:38 PST, Erik Arvidsson 		no flags
DetailsFormatted DiffDiff
Patch (19.21 KB, patch)
2011-11-29 14:48 PST, Erik Arvidsson 		abarth: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Erik Arvidsson
Comment 1 2011-11-28 12:02:24 PST
It turns out that CodeGeneratorV8.pm already supports this using [ClassMethod] I plan to change the code generator to use "static" instead but a as a first step I am going to make CodeGeneratorJS support [ClassMethod] too.
Erik Arvidsson
Comment 2 2011-11-29 14:38:26 PST
Created attachment 117047 [details] Patch
Erik Arvidsson
Comment 3 2011-11-29 14:48:01 PST
Created attachment 117048 [details] Patch
Erik Arvidsson
Comment 4 2011-11-29 16:40:41 PST
webkit-patch land failed Commited as http://trac.webkit.org/changeset/101433
Note You need to log in before you can comment on or make changes to this bug.