Bug 72975

Summary: UString methods are not character size aware
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch fpizlo: review+

Description Michael Saboff 2011-11-22 10:58:26 PST 
Various UString methods do not take into account the character size of their arguments.  Also the constructors that convert numbers to strings create 16 bit strings.
Comment 1 Michael Saboff 2011-11-22 11:07:24 PST 
Created attachment 116252 [details]
Patch
Comment 2 Filip Pizlo 2011-11-24 11:10:15 PST 
Comment on attachment 116252 [details]
Patch

What is the performance effect, if any?
Comment 3 Michael Saboff 2011-11-24 22:55:14 PST 
(In reply to comment #2)
> (From update of attachment 116252 [details])
> What is the performance effect, if any?

This change appears neutral on SunSpider.  Together with other changes it provides a benefit on SunSpider.
Comment 4 Michael Saboff 2011-11-24 22:55:52 PST 
Committed r101152: <http://trac.webkit.org/changeset/101152>