Bug 72968

Summary: Empty JSStrings are created as 16 bit
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 72969    
Attachments:
Description Flags
Patch fpizlo: review+

Michael Saboff
Reported 2011-11-22 10:25:26 PST
An empty JSString is created with the m_is8Bit member clear. Therefore if an empty string is created and an 8 bit JSString is appended, the resulting JSString will have the 8 bit flag cleared but it should be 8 bit.
Attachments
Patch (1.10 KB, patch)
2011-11-22 10:35 PST, Michael Saboff 		fpizlo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2011-11-22 10:35:57 PST
Created attachment 116244 [details] Patch
Filip Pizlo
Comment 2 2011-11-24 11:05:45 PST
Comment on attachment 116244 [details] Patch What is the performance effect if any?
Michael Saboff
Comment 3 2011-11-24 22:28:19 PST
(In reply to comment #2) > (From update of attachment 116244 [details]) > What is the performance effect if any? BY itself, this patch is a wash. It provides a benefit together with other changes.
Michael Saboff
Comment 4 2011-11-24 22:36:16 PST
Committed r101148: <http://trac.webkit.org/changeset/101148>
Note You need to log in before you can comment on or make changes to this bug.