Bug 72958

Summary: CSSStyleDeclaration: Kill FIXME in setProperty().
Product: WebKit Reporter: Andreas Kling <kling>
Component: CSSAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: macpherson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Andreas Kling 2011-11-22 07:28:49 PST 
The current behavior of setProperty() to not throw exceptions for invalid property names is correct as specified by CSSOM ( http://dev.w3.org/csswg/cssom/#dom-cssstyledeclaration-setproperty ), so we can remove the FIXME about throwing an exception for that case.
Comment 1 Andreas Kling 2011-11-22 07:32:22 PST 
Created attachment 116225 [details]
Patch
Comment 2 Antonio Gomes 2011-11-22 07:50:22 PST 
Comment on attachment 116225 [details]
Patch

If you really want you could even add a test to be sure we do not throw an exception when we set a invalid property :-)
Comment 3 WebKit Review Bot 2011-11-22 09:40:10 PST 
Comment on attachment 116225 [details]
Patch

Clearing flags on attachment: 116225

Committed r101007: <http://trac.webkit.org/changeset/101007>
Comment 4 WebKit Review Bot 2011-11-22 09:40:14 PST 
All reviewed patches have been landed.  Closing bug.