Bug 72940

Summary:

A test that mutation happens when asynchronous spell checking is in process.

Product:

WebKit

Reporter:

Shinya Kawanaka <shinyak>

Component:

UI Events

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

morrita, shinyak, shinyak, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

74479, 71991

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Shinya Kawanaka

Reported 2011-11-22 04:49:40 PST

A test that mutation happens in asynchronous spellchecking lacks. This is required.

Attachments
Patch (9.55 KB, patch) 2011-12-14 21:54 PST, Shinya Kawanaka	no flags	Details Formatted Diff Diff
Patch (11.27 KB, patch) 2011-12-15 19:39 PST, Shinya Kawanaka	no flags	Details Formatted Diff Diff
Patch (11.29 KB, patch) 2011-12-18 21:42 PST, Shinya Kawanaka	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Shinya Kawanaka

Comment 1 2011-12-14 21:54:51 PST

Created attachment 119373 [details] Patch

Hajime Morrita

Comment 2 2011-12-15 02:37:05 PST

Comment on attachment 119373 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119373&action=review Could you check actual marker existence? > LayoutTests/editing/spelling/spellcheck-async-mutation.html:125 > + function selectAll(elem) { It doesn't look to select all.

Shinya Kawanaka

Comment 3 2011-12-15 19:39:25 PST

Created attachment 119544 [details] Patch

Shinya Kawanaka

Comment 4 2011-12-15 19:42:32 PST

(In reply to comment #2) > (From update of attachment 119373 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=119373&action=review > > Could you check actual marker existence? Done. In 'move', markers are there on the original (moved) element In 'mutate', marker disappears as expected. In 'mutate', I've changed "zz, zz, zz" to "zzz". So the first "zz" are the same, we afraid that "zz" might be marked. But that case didn't happen. > > > LayoutTests/editing/spelling/spellcheck-async-mutation.html:125 > > + function selectAll(elem) { > > It doesn't look to select all. Done.

WebKit Review Bot

Comment 5 2011-12-16 01:05:06 PST

Comment on attachment 119544 [details] Patch Clearing flags on attachment: 119544 Committed r103044: <http://trac.webkit.org/changeset/103044>

WebKit Review Bot

Comment 6 2011-12-16 01:05:11 PST

All reviewed patches have been landed. Closing bug.

Hajime Morrita

Comment 7 2011-12-16 03:10:46 PST

Reverted r103044 for reason: Added test doesn't pass on Mac SL and Mac Chromium Committed r103053: <http://trac.webkit.org/changeset/103053>

Hajime Morrita

Comment 8 2011-12-16 03:13:32 PST

This isn't real failure but the timing when "TEST COMPLETE" is printed was different between Mac, Chromium/Mac and others. We need to find the way to stabilize it.

Shinya Kawanaka

Comment 9 2011-12-18 21:42:35 PST

Created attachment 119812 [details] Patch

Shinya Kawanaka

Comment 10 2011-12-18 21:43:02 PST

(In reply to comment #9) > Created an attachment (id=119812) [details] > Patch This is a try to stabilize the test.

WebKit Review Bot

Comment 11 2011-12-18 23:00:10 PST

Comment on attachment 119812 [details] Patch Clearing flags on attachment: 119812 Committed r103220: <http://trac.webkit.org/changeset/103220>

WebKit Review Bot

Comment 12 2011-12-18 23:00:15 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.