Bug 72914

Summary: [Qt][WK2] Move QQuickWebView::downloadRequested signal into experimental
Product: WebKit Reporter: Jesus Sanchez-Palencia <jesus>
Component: WebKit QtAssignee: Jesus Sanchez-Palencia <jesus>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, webkit.review.bot, zoltan
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Jesus Sanchez-Palencia
Reported 2011-11-21 14:59:39 PST
"[Qt][WK2] Move QQuickWebView::downloadRequested signal into experimental"
Attachments
Patch (9.50 KB, patch)
2011-11-21 15:03 PST, Jesus Sanchez-Palencia 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jesus Sanchez-Palencia
Comment 1 2011-11-21 15:03:57 PST
Created attachment 116143 [details] Patch
Andreas Kling
Comment 2 2011-11-23 09:04:31 PST
Comment on attachment 116143 [details] Patch rs=mø
WebKit Review Bot
Comment 3 2011-11-23 09:06:55 PST
Comment on attachment 116143 [details] Patch Rejecting attachment 116143 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: UIProcess/API/qt/tests/qmltests/common/download.html' patching file Source/WebKit2/UIProcess/API/qt/tests/qmltests/qmltests.pro Hunk #1 FAILED at 24. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit2/UIProcess/API/qt/tests/qmltests/qmltests.pro.rej patching file Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp Hunk #1 succeeded at 834 (offset -84 lines). Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Andreas Kling', u'--fo..." exit_code: 1 Full output: http://queues.webkit.org/results/10607356
Jesus Sanchez-Palencia
Comment 4 2011-11-23 14:04:20 PST
Committed r101103: <http://trac.webkit.org/changeset/101103>
Note You need to log in before you can comment on or make changes to this bug.