Bug 72869

Summary: [Qt] Clean up MiniBrowser project file after recent changes
Product: WebKit Reporter: Andras Becsi <abecsi>
Component: Tools / TestsAssignee: Andras Becsi <abecsi>
Status: RESOLVED FIXED    
Severity: Normal CC: vestbo, webkit.review.bot
Priority: P3 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
proposed patch
vestbo: review-
proposed patch none

Andras Becsi
Reported 2011-11-21 04:05:52 PST
We use OTHER_FILES for the QML files to be listed in Qt Creator. Remove nonexistent files from OTHER_FILES and add the remainig only QML file as a dependency of the project.
Attachments
proposed patch (1.13 KB, patch)
2011-11-21 04:07 PST, Andras Becsi 		vestbo: review-
DetailsFormatted DiffDiff
proposed patch (1.05 KB, patch)
2011-11-21 04:35 PST, Andras Becsi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andras Becsi
Comment 1 2011-11-21 04:07:37 PST
Created attachment 116063 [details] proposed patch
WebKit Review Bot
Comment 2 2011-11-21 04:10:14 PST
Attachment 116063 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/MiniBrowser/qt/M..." exit_code: 1 Tools/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tor Arne Vestbø
Comment 3 2011-11-21 04:25:57 PST
Comment on attachment 116063 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=116063&action=review > Tools/MiniBrowser/qt/MiniBrowser.pro:40 > +PRE_TARGETDEPS += $$OTHER_FILES This should be handled by CONFIG += resources. If that's broken we should look at what's going on.
Andras Becsi
Comment 4 2011-11-21 04:35:45 PST
Created attachment 116069 [details] proposed patch rcc should take care of the dependency, so the dependency bug should not be the scope of this change.
Andras Becsi
Comment 5 2011-11-21 07:00:06 PST
Comment on attachment 116069 [details] proposed patch Clearing flags on attachment: 116069 Committed r100910: <http://trac.webkit.org/changeset/100910>
Andras Becsi
Comment 6 2011-11-21 07:00:13 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.