| Summary: | [Qt] Clean up MiniBrowser project file after recent changes | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andras Becsi <abecsi> | ||||||
| Component: | Tools / Tests | Assignee: | Andras Becsi <abecsi> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | vestbo, webkit.review.bot | ||||||
| Priority: | P3 | Keywords: | Qt | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
|
Description
Andras Becsi
2011-11-21 04:05:52 PST
Created attachment 116063 [details]
proposed patch
Attachment 116063 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/MiniBrowser/qt/M..." exit_code: 1
Tools/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 116063 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=116063&action=review > Tools/MiniBrowser/qt/MiniBrowser.pro:40 > +PRE_TARGETDEPS += $$OTHER_FILES This should be handled by CONFIG += resources. If that's broken we should look at what's going on. Created attachment 116069 [details]
proposed patch
rcc should take care of the dependency, so the dependency bug should not be the scope of this change.
Comment on attachment 116069 [details] proposed patch Clearing flags on attachment: 116069 Committed r100910: <http://trac.webkit.org/changeset/100910> All reviewed patches have been landed. Closing bug. |