Summary: | REGRESSION(r100856): New test fast/css/style-tag-display-none.html fails on Chromium (Requested by steveblock on #webkit). | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | WebKit Review Bot <webkit.review.bot> | ||||
Component: | New Bugs | Assignee: | WebKit Review Bot <webkit.review.bot> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | davidbarr, dglazkov, eric, koivisto, macpherson, mikelawther | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 71703 | ||||||
Attachments: |
|
Description
WebKit Review Bot
2011-11-21 03:05:48 PST
Created attachment 116058 [details] ROLLOUT of r100856 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. Comment on attachment 116058 [details] ROLLOUT of r100856 Clearing flags on attachment: 116058 Committed r100896: <http://trac.webkit.org/changeset/100896> All reviewed patches have been landed. Closing bug. Did it need a rebaseline? What was the issue? Please comment in the original bug when you roll out changes to explain why you're rolling them out. :( I chatted with Steve on IRC after the rollback. He said it was because the result was labelled as 'MISSING', rather than any tests actually failing. I don't know why the bots were thinking the test result was missing, since the test and the result were committed at the same time into the same directory. (In reply to comment #5) > I chatted with Steve on IRC after the rollback. He said it was because the result was labelled as 'MISSING', rather than any tests actually failing. > > I don't know why the bots were thinking the test result was missing, since the test and the result were committed at the same time into the same directory. It looks like the were no pixel results submitted with the test. Actually -- this test could totally be dumpAsText, no need for platform-specific pixel results. (In reply to comment #6) > Actually -- this test could totally be dumpAsText, no need for platform-specific pixel results. I don't think so. The bug tested is very sensitive to the exact document structure. Inclusion of <script> in the head likely to make the bug disappear. It would actually be good to mention that in the test case. |