Bug 72865

Summary: [Qt] WebSocket close tests are failing
Product: WebKit Reporter: Yuta Kitamura <yutak>
Component: New BugsAssignee: Yuta Kitamura <yutak>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, webkit.review.bot, yael
Priority: P3 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Description Yuta Kitamura 2011-11-21 00:44:53 PST
The following five tests are failing:

- http/tests/websocket/tests/hybi/close-before-open.html
- http/tests/websocket/tests/hybi/close-code-and-reason.html
- http/tests/websocket/tests/hybi/close.html
- http/tests/websocket/tests/hybi/workers/close.html
- http/tests/websocket/tests/hybi/workers/close-code-and-reason.html

These tests are failing because SocketStreamHandleQt::platformClose() does not emit didCloseSocketStream() callback when it is called before the connection is established.

I'm going to post a patch shortly.
Comment 1 Yuta Kitamura 2011-11-21 00:59:46 PST
Created attachment 116048 [details]
Patch
Comment 2 Simon Hausmann 2011-11-21 01:24:25 PST
Comment on attachment 116048 [details]
Patch

Thanks!
Comment 3 WebKit Review Bot 2011-11-21 01:43:14 PST
Comment on attachment 116048 [details]
Patch

Clearing flags on attachment: 116048

Committed r100891: <http://trac.webkit.org/changeset/100891>
Comment 4 WebKit Review Bot 2011-11-21 01:43:18 PST
All reviewed patches have been landed.  Closing bug.