Bug 72827

Summary: [Qt] [WK2] WebKitTestRunner doesn't build in debug
Product: WebKit Reporter: Viatcheslav Ostapenko <ostap73>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: levin+threading, ossy, webkit.review.bot
Priority: P3 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Viatcheslav Ostapenko
Reported 2011-11-20 11:34:50 PST
obj/debug/EventSenderProxyQt.o: In function `WTR::EventSenderProxy::updateTouchPoint(int, int, int)': /home/sl/work/webkit/WebKitBuild/Debug/Tools/WebKitTestRunner/../../../../Tools/WebKitTestRunner/qt/EventSenderProxyQt.cpp:325: undefined reference to `WTFReportAssertionFailure' obj/debug/TestControllerQt.o: In function `WTR::TestControllerRunLoop::start(int)': /home/sl/work/webkit/WebKitBuild/Debug/Tools/WebKitTestRunner/../../../../Tools/WebKitTestRunner/qt/TestControllerQt.cpp:56: undefined reference to `WTFReportAssertionFailure' obj/debug/TestInvocationQt.o: In function `WTR::TestInvocation::dumpPixelsAndCompareWithExpected(OpaqueWKImage const*, OpaqueWKArray const*)': /home/sl/work/webkit/WebKitBuild/Debug/Tools/WebKitTestRunner/../../../../Tools/WebKitTestRunner/qt/TestInvocationQt.cpp:76: undefined reference to `WTFReportAssertionFailure' obj/debug/TestController.o: In function `WTR::TestController::shared()': /home/sl/work/webkit/WebKitBuild/Debug/Tools/WebKitTestRunner/../../../../Tools/WebKitTestRunner/TestController.cpp:60: undefined reference to `WTFReportAssertionFailure' obj/debug/TestController.o: In function `WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle(OpaqueWKString const*, void const*)': /home/sl/work/webkit/WebKitBuild/Debug/Tools/WebKitTestRunner/../../../../Tools/WebKitTestRunner/TestController.cpp:546: undefined reference to `WTFReportAssertionFailure' obj/debug/TestController.o:/home/sl/work/webkit/WebKitBuild/Debug/Tools/WebKitTestRunner/../../../../Tools/WebKitTestRunner/TestController.cpp:694: more undefined references to `WTFReportAssertionFailure' follow collect2: ld returned 1 exit status
Attachments
Patch (1.17 KB, patch)
2011-11-20 11:59 PST, Viatcheslav Ostapenko 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Viatcheslav Ostapenko
Comment 1 2011-11-20 11:59:08 PST
Created attachment 115990 [details] Patch
Andreas Kling
Comment 2 2011-11-20 13:15:08 PST
Comment on attachment 115990 [details] Patch rs=me
WebKit Review Bot
Comment 3 2011-11-20 14:21:52 PST
Comment on attachment 115990 [details] Patch Rejecting attachment 115990 [details] from commit-queue. New failing tests: platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html Full output: http://queues.webkit.org/results/10534064
Viatcheslav Ostapenko
Comment 4 2011-11-20 15:02:04 PST
(In reply to comment #3) > (From update of attachment 115990 [details]) > Rejecting attachment 115990 [details] from commit-queue. > > New failing tests: > platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html > Full output: http://queues.webkit.org/results/10534064 Wow! How change in Qt exports could fail chromium layout tests? ;)
Viatcheslav Ostapenko
Comment 5 2011-11-21 07:11:12 PST
Comment on attachment 115990 [details] Patch I'd like to retry commit queue because this change couldn't break chromium layout tests.
Csaba Osztrogonác
Comment 6 2011-11-21 08:49:00 PST
Comment on attachment 115990 [details] Patch Clearing flags on attachment: 115990 Committed r100920: <http://trac.webkit.org/changeset/100920>
Csaba Osztrogonác
Comment 7 2011-11-21 08:49:08 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.