| Summary: | Remove the dependence on jsonp from more of new-run-webkit-tests and the test results server | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ojan Vafai <ojan> | ||||
| Component: | New Bugs | Assignee: | Ojan Vafai <ojan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Ojan Vafai
2011-11-19 16:47:30 PST
Created attachment 115963 [details]
Patch
Comment on attachment 115963 [details]
Patch
Do we need to change anything in garden-o-matic? It has some code to strip off the JSONP wrapper. We might need to change it to detect whether the wrapper is there in the first place (or maybe it already does that).
Comment on attachment 115963 [details]
Patch
I'll just commit this now.
I think garden-o-matic is OK, but I'll double-check before commiting. As best I can tell, garden-o-matic only reads full_results.json, which is the only one that's not changing (i.e. it's keeping the jsonp wrapper). Ok. Should we remove the wrapper from that one too? Committed r100862: <http://trac.webkit.org/changeset/100862> (In reply to comment #6) > Ok. Should we remove the wrapper from that one too? There's a comment in the code about why we can't. After run-webkit-tests, we load results.html as a file URL in the browser. results.html pulls in full_results.json as a file URL. This doesn't work in chromium. So, I'm not really sure how we could fix this without running a local server, which I don't think people would be happy about for run-webkit-tests. |