Bug 72812

Summary: [CMake] Make the feature defines for DOM names explicit
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: Tools / TestsAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, dbates, gyuyoung.kim, leandro, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 72815    
Attachments:
Description Flags
Patch
gyuyoung.kim: commit-queue-
Patch
none
Patch none

Patrick R. Gansterer
Reported 2011-11-19 15:34:28 PST
[CMake] Make the feature defines for DOM names explicit
Attachments
Patch (11.41 KB, patch)
2011-11-19 15:39 PST, Patrick R. Gansterer 		gyuyoung.kim: commit-queue-
DetailsFormatted DiffDiff
Patch (11.41 KB, patch)
2011-11-23 08:19 PST, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (11.35 KB, patch)
2011-11-24 02:14 PST, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2011-11-19 15:39:21 PST
Created attachment 115962 [details] Patch
Gyuyoung Kim
Comment 2 2011-11-19 15:55:13 PST
Comment on attachment 115962 [details] Patch Attachment 115962 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/10417151
Patrick R. Gansterer
Comment 3 2011-11-23 08:19:02 PST
Created attachment 116359 [details] Patch
Gyuyoung Kim
Comment 4 2011-11-23 17:55:44 PST
Comment on attachment 116359 [details] Patch Attachment 116359 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/10618191
Gyuyoung Kim
Comment 5 2011-11-23 18:34:04 PST
Comment on attachment 116359 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=116359&action=review > Source/cmake/WebKitFeatures.cmake:-46 > - IF (${_feature}) There are EFL build breaks by this removal.
Patrick R. Gansterer
Comment 6 2011-11-24 02:14:42 PST
Created attachment 116489 [details] Patch
WebKit Review Bot
Comment 7 2011-12-01 10:31:00 PST
Comment on attachment 116489 [details] Patch Clearing flags on attachment: 116489 Committed r101685: <http://trac.webkit.org/changeset/101685>
WebKit Review Bot
Comment 8 2011-12-01 10:31:05 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.