Bug 72735

Summary: [GTK] Don't load GAIL when using GTK 3.2 or greater
Product: WebKit Reporter: Mario Sanchez Prada <mario>
Component: WebKitGTKAssignee: Anton Obzhirov <obzhirov>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, gustavo, mrobinson, obzhirov, pnormand
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Mario Sanchez Prada
Reported 2011-11-18 09:00:36 PST
As it was suggested by Philippe in bug 72732 (https://bugs.webkit.org/show_bug.cgi?id=72732#c2), opening this bug to remind that GAIL shouldn't be loaded after upgrading to GTK 3.2, since it will stop being a GTK+ module from that version on (it will become part of GTK+ itself). Among perhaps other implications, one is that using initializeTestingFramework() in testatk.c shouldn't be needed anymore since GTK 3.2, and so it should be replaced by gtk_test_init().
Attachments
Patch (4.00 KB, patch)
2013-08-12 03:17 PDT, Anton Obzhirov 		no flags
DetailsFormatted DiffDiff
Patch (4.01 KB, patch)
2013-08-12 05:35 PDT, Anton Obzhirov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mario Sanchez Prada
Comment 1 2013-08-12 03:05:25 PDT
*** Bug 119675 has been marked as a duplicate of this bug. ***
Anton Obzhirov
Comment 2 2013-08-12 03:17:44 PDT
Created attachment 208525 [details] Patch
WebKit Commit Bot
Comment 3 2013-08-12 03:19:40 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Carlos Garcia Campos
Comment 4 2013-08-12 03:30:56 PDT
Comment on attachment 208525 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208525&action=review > Source/WebKit2/UIProcess/API/gtk/tests/AccessibilityTestServer.cpp:34 > + // Make sure that the ATK bridge are loaded. s/are/is/
Anton Obzhirov
Comment 5 2013-08-12 05:35:37 PDT
Created attachment 208536 [details] Patch Thanks Carlos for the review. Now uploading a new patch since I'm not a committer yet
Mario Sanchez Prada
Comment 6 2013-08-12 05:36:25 PDT
Comment on attachment 208536 [details] Patch Just setting the cq+ flag
WebKit Commit Bot
Comment 7 2013-08-12 10:15:12 PDT
Comment on attachment 208536 [details] Patch Clearing flags on attachment: 208536 Committed r153947: <http://trac.webkit.org/changeset/153947>
WebKit Commit Bot
Comment 8 2013-08-12 10:15:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.