Bug 72734

Summary: Web Inspector:[protocol] actual JSON messages do not conform to Inspector.json in InspectorApplicationCacheAgent.cpp
Product: WebKit Reporter: Peter Rybin <peter.rybin>
Component: Web Inspector (Deprecated)Assignee: Vsevolod Vlasov <vsevik>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, peter.rybin, pfeldman, pmuellr, rik, timothy, vsevik, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 72824    
Attachments:
Description Flags
Patch none

Peter Rybin
Reported 2011-11-18 08:59:28 PST
InspectorApplicationCacheAgent.cpp:188 (r100177) size is declared 'string', but actual type is 'integer'; why 'size' is declared 'string' in the first place?
Attachments
Patch (1.52 KB, patch)
2011-11-19 08:37 PST, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Peter Rybin
Comment 1 2011-11-18 09:07:21 PST
This should be fixed to conform to protocol declaration AND to prepare switching to type-safe JSON API.
Vsevolod Vlasov
Comment 2 2011-11-19 08:37:49 PST
Created attachment 115951 [details] Patch
WebKit Review Bot
Comment 3 2011-11-19 09:32:38 PST
Comment on attachment 115951 [details] Patch Clearing flags on attachment: 115951 Committed r100857: <http://trac.webkit.org/changeset/100857>
WebKit Review Bot
Comment 4 2011-11-19 09:32:43 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.