Bug 72717

Summary: [Qt][WK2] setViewportInteractionEngine must also set the InteractionEngine for the tap recognizer
Product: WebKit Reporter: Zeno Albisser <zeno>
Component: WebKit QtAssignee: Zeno Albisser <zeno>
Status: RESOLVED FIXED    
Severity: Normal CC: kenneth, webkit.review.bot, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch for review.
none
patch for review. none

Zeno Albisser
Reported 2011-11-18 05:28:33 PST
SSIA
Attachments
patch for review. (2.28 KB, patch)
2011-11-18 05:31 PST, Zeno Albisser 		no flags
DetailsFormatted DiffDiff
patch for review. (3.76 KB, patch)
2011-11-18 05:43 PST, Zeno Albisser 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zeno Albisser
Comment 1 2011-11-18 05:31:56 PST
Created attachment 115787 [details] patch for review.
WebKit Review Bot
Comment 2 2011-11-18 05:34:34 PST
Attachment 115787 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/UIProcess/qt/QtWebPageProxy.h:184: The parameter name "engine" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Zeno Albisser
Comment 3 2011-11-18 05:34:41 PST
Comment on attachment 115787 [details] patch for review. there is still something missing.
Zeno Albisser
Comment 4 2011-11-18 05:43:09 PST
Created attachment 115791 [details] patch for review.
Zeno Albisser
Comment 5 2011-11-18 05:49:10 PST
Comment on attachment 115791 [details] patch for review. Clearing flags on attachment: 115791 Committed r100760: <http://trac.webkit.org/changeset/100760>
Zeno Albisser
Comment 6 2011-11-18 05:49:19 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.