Bug 72673

Summary:

Teach TextFileReader about FileSystem

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

New Bugs

Assignee:

Eric Seidel (no email) <eric>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, levin, ojan, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	abarth: review+, abarth: commit-queue+

Description Eric Seidel (no email) 2011-11-17 15:44:53 PST

Teach TextFileReader about FileSystem

Comment 1 Eric Seidel (no email) 2011-11-17 15:45:58 PST

Created attachment 115701 [details]
Patch

Comment 2 David Levin 2011-11-17 15:50:08 PST

Comment on attachment 115701 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=115701&action=review

> Tools/Scripts/webkitpy/style/filereader.py:64
> +        # FIXME: Although TextFileReader requires a FileSystem it circumvents it in two places!

It looks like you only flagged one place with a FIXME.

Comment 3 Eric Seidel (no email) 2011-11-17 15:55:28 PST

Committed r100694: <http://trac.webkit.org/changeset/100694>