Bug 72673

Summary: Teach TextFileReader about FileSystem
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, levin, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch abarth: review+, abarth: commit-queue+

Eric Seidel (no email)
Reported 2011-11-17 15:44:53 PST
Teach TextFileReader about FileSystem
Attachments
Patch (8.40 KB, patch)
2011-11-17 15:45 PST, Eric Seidel (no email) 		abarth: review+
abarth: commit-queue+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2011-11-17 15:45:58 PST
Created attachment 115701 [details] Patch
David Levin
Comment 2 2011-11-17 15:50:08 PST
Comment on attachment 115701 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=115701&action=review > Tools/Scripts/webkitpy/style/filereader.py:64 > + # FIXME: Although TextFileReader requires a FileSystem it circumvents it in two places! It looks like you only flagged one place with a FIXME.
Eric Seidel (no email)
Comment 3 2011-11-17 15:55:28 PST
Committed r100694: <http://trac.webkit.org/changeset/100694>
Note You need to log in before you can comment on or make changes to this bug.