Bug 72669

Summary: [chromium] Disable incremental uploading in threaded compositing path
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: cc-bugs, enne, nduca, reveman, shawnsingh, vangelis, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

James Robinson
Reported 2011-11-17 15:15:11 PST
[chromium] Disable incremental uploading in threaded compositing path
Attachments
Patch (1.91 KB, patch)
2011-11-17 15:16 PST, James Robinson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2011-11-17 15:16:38 PST
Created attachment 115696 [details] Patch
Nat Duca
Comment 2 2011-11-17 15:20:57 PST
Comment on attachment 115696 [details] Patch LGTM but lets get someone working on fixing this. When the prerenderer patch lands, we're gonna need this I fear.
Adrienne Walker
Comment 3 2011-11-17 15:23:30 PST
Comment on attachment 115696 [details] Patch Looks good to me. I had intended this to be something we could play with for performance, and disabling it until we can make it correct seems like the right choice.
Kenneth Russell
Comment 4 2011-11-17 15:25:20 PST
Comment on attachment 115696 [details] Patch rs=me
Shawn Singh
Comment 5 2011-11-17 15:26:56 PST
(In reply to comment #2) > (From update of attachment 115696 [details]) > LGTM but lets get someone working on fixing this. When the prerenderer patch lands, we're gonna need this I fear. Just for completeness, can you please point to our so-called "prerenderer patch"? Or are you just referring to intended design that we're working towards?
Adrienne Walker
Comment 6 2011-11-17 15:33:34 PST
(In reply to comment #5) > Just for completeness, can you please point to our so-called "prerenderer patch"? Or are you just referring to intended design that we're working towards? Eric Penner sounded like he'd have a patch up soon.
WebKit Review Bot
Comment 7 2011-11-17 20:09:21 PST
Comment on attachment 115696 [details] Patch Clearing flags on attachment: 115696 Committed r100710: <http://trac.webkit.org/changeset/100710>
WebKit Review Bot
Comment 8 2011-11-17 20:09:26 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.