Bug 72665

Summary: Switch to a more modern approach to retrieving the OS marketing version
Product: WebKit Reporter: Mark Rowe (bdash) <mrowe>
Component: WebKit Misc.Assignee: Mark Rowe (bdash) <mrowe>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch v1
none
Patch v2 mitz: review+

Mark Rowe (bdash)
Reported 2011-11-17 14:50:34 PST
As it says!
Attachments
Patch v1 (6.70 KB, patch)
2011-11-17 14:55 PST, Mark Rowe (bdash) 		no flags
DetailsFormatted DiffDiff
Patch v2 (9.79 KB, patch)
2011-11-27 15:02 PST, Mark Rowe (bdash) 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Rowe (bdash)
Comment 1 2011-11-17 14:55:36 PST
Created attachment 115694 [details] Patch v1
Mark Rowe (bdash)
Comment 2 2011-11-27 15:02:17 PST
Created attachment 116682 [details] Patch v2
mitz
Comment 3 2011-11-27 15:05:48 PST
Comment on attachment 116682 [details] Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=116682&action=review > Source/WebCore/platform/mac/WebCoreSystemInterface.h:322 > +extern NSString* (*wkGetMacOSXVersionString)(void); There should be a space after NSString
Mark Rowe (bdash)
Comment 4 2011-11-27 15:48:17 PST
Landed in r101215.
Adam Roben (:aroben)
Comment 5 2011-11-28 06:34:34 PST
Looks like this caused bug 73214.
Note You need to log in before you can comment on or make changes to this bug.