Bug 72643

Summary: [CMake] Add ENABLE_CLIENT_BASED_GEOLOCATION to cmakeconfig.h
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: Tools / TestsAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Patrick R. Gansterer
Reported 2011-11-17 12:25:30 PST
[CMake] Add ENABLE_CLIENT_BASED_GEOLOCATION to cmakeconfig.h
Attachments
Patch (4.28 KB, patch)
2011-11-17 12:26 PST, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2011-11-17 12:26:22 PST
Created attachment 115658 [details] Patch
Brent Fulgham
Comment 2 2011-11-17 14:04:06 PST
Comment on attachment 115658 [details] Patch Looks good to me. The supposedly-failing chromium tests can't possibly be affected by this change.
Patrick R. Gansterer
Comment 3 2011-11-17 14:05:49 PST
Comment on attachment 115658 [details] Patch (In reply to comment #2) > (From update of attachment 115658 [details]) > Looks good to me. The supposedly-failing chromium tests can't possibly be affected by this change. Since chromium does not use CMake: NO! ;-)
WebKit Review Bot
Comment 4 2011-11-17 15:15:14 PST
Comment on attachment 115658 [details] Patch Clearing flags on attachment: 115658 Committed r100686: <http://trac.webkit.org/changeset/100686>
WebKit Review Bot
Comment 5 2011-11-17 15:15:18 PST
All reviewed patches have been landed. Closing bug.
Raphael Kubo da Costa (:rakuco)
Comment 6 2011-11-18 08:07:24 PST
This patch broke the EFL build with ENABLE_GEOLOCATION (and most likely platform/mock/GeolocationServiceMock.cpp too), as they do not check for ENABLE_CLIENT_BASED_GEOLOCATION and define s_factoryFunction regardless of whether GeolocationService.cpp also does so.
Note You need to log in before you can comment on or make changes to this bug.