| Summary: | fuzzy_match doesn't recognize "Dan B" or "hyatt" | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||
| Component: | Tools / Tests | Assignee: | Ryosuke Niwa <rniwa> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, eric, ojan, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 26533, 72243 | ||||||
| Attachments: |
|
||||||
|
Description
Ryosuke Niwa
2011-11-17 11:46:39 PST
Created attachment 115653 [details]
fixes the bug
Comment on attachment 115653 [details] fixes the bug Curious if you looked at bug 26533 at all. It had to solve these very same problems. (You're doing a much nicer job, of course.) :) (In reply to comment #2) > (From update of attachment 115653 [details]) > Curious if you looked at bug 26533 at all. It had to solve these very same problems. (You're doing a much nicer job, of course.) :) Yeah, I've looked at your script. What I'm trying to do is to minimize the hard-coded list of things so that it can adopt to new misspells and new contributors better. Eventually, fuzz_match should be able to recognize any name listed in your original script :) Do you have any suggestion to the patch? Comment on attachment 115653 [details] fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=115653&action=review Seems OK. You should add a comment about the commented out code, since we don't normally commit commented out code. > Tools/Scripts/webkitpy/common/config/committers.py:539 > + if email[:len(string)] == string: Why not just .startswith? > Tools/Scripts/webkitpy/common/config/committers.py:545 > + if not ' ' in contributor.full_name: ' ' not in foo works too. > Tools/Scripts/webkitpy/common/config/committers.py:550 > + first_name = split_fullname[0] > + last_name = split_fullname[-1] > + return first_name, last_name, first_name + last_name[0], first_name + ' ' + last_name[0] This is kinda a big hack, but OK. You might want to put this on Contributor itself in a later patch. Not sure. Thanks for the review. Will address all comments and land. Committed r100700: <http://trac.webkit.org/changeset/100700> |