Bug 72635

Summary: NRWT crashes when parsing leaks files from which certain leaks were excluded
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: Tools / TestsAssignee: Adam Roben (:aroben) <aroben>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, darin, ddkilzer, eric, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch abarth: review+

Description Adam Roben (:aroben) 2011-11-17 11:43:16 PST
NRWT crashes when parsing leaks files from which certain leaks were excluded
Comment 1 Adam Roben (:aroben) 2011-11-17 11:43:41 PST
Created attachment 115640 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-11-17 11:55:38 PST
Comment on attachment 115640 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=115640&action=review

> Tools/Scripts/webkitpy/layout_tests/port/leakdetector.py:99
> -        excluded = excluded_match.group(0) if excluded_match else 0
> +        excluded = excluded_match.group('excluded') if excluded_match else 0

Sorry.  I think I broke this last time I was in here.  Again, sadly untested and thus broke.  Thanks!
Comment 3 Adam Roben (:aroben) 2011-11-17 11:58:59 PST
Committed r100655: <http://trac.webkit.org/changeset/100655>