Summary: | NRWT crashes when parsing leaks files from which certain leaks were excluded | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||
Component: | Tools / Tests | Assignee: | Adam Roben (:aroben) <aroben> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, darin, ddkilzer, eric, ojan, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Adam Roben (:aroben)
2011-11-17 11:43:16 PST
Created attachment 115640 [details]
Patch
Comment on attachment 115640 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=115640&action=review > Tools/Scripts/webkitpy/layout_tests/port/leakdetector.py:99 > - excluded = excluded_match.group(0) if excluded_match else 0 > + excluded = excluded_match.group('excluded') if excluded_match else 0 Sorry. I think I broke this last time I was in here. Again, sadly untested and thus broke. Thanks! Committed r100655: <http://trac.webkit.org/changeset/100655> |