Bug 72611

Summary: MediaStream API: Merging the PeerConnectionHandler.h files
Product: WebKit Reporter: Tommy Widenflycht <tommyw>
Component: WebKit Misc.Assignee: Tommy Widenflycht <tommyw>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, adam.bergkvist, dglazkov, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Tommy Widenflycht
Reported 2011-11-17 07:57:26 PST
As discussed a while back Ericsson expressed a wish for the header files to be unified, and as long as the #ifdefs are kept to a minimum I see the advantage.
Attachments
Patch (13.47 KB, patch)
2011-11-17 08:00 PST, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Patch (13.53 KB, patch)
2011-11-18 00:30 PST, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tommy Widenflycht
Comment 1 2011-11-17 08:00:58 PST
Created attachment 115590 [details] Patch
WebKit Review Bot
Comment 2 2011-11-17 08:43:32 PST
Comment on attachment 115590 [details] Patch Attachment 115590 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10312190
Adam Barth
Comment 3 2011-11-17 10:28:47 PST
Comment on attachment 115590 [details] Patch Ok.
Tommy Widenflycht
Comment 4 2011-11-18 00:30:42 PST
Created attachment 115754 [details] Patch
WebKit Review Bot
Comment 5 2011-11-18 02:05:32 PST
Comment on attachment 115754 [details] Patch Clearing flags on attachment: 115754 Committed r100734: <http://trac.webkit.org/changeset/100734>
WebKit Review Bot
Comment 6 2011-11-18 02:05:37 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.