Bug 72544

Summary: DropShadowFilterOperation violates platform isolation
Product: WebKit Reporter: Dean Jackson <dino>
Component: CSSAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, macpherson, sam, simon.fraser, webkit-bug-importer, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch simon.fraser: review+

Dean Jackson
Reported 2011-11-16 13:59:50 PST
The DropShadowFilterOperation references ShadowData. It shouldn't.
Attachments
Patch (5.21 KB, patch)
2011-11-16 14:55 PST, Dean Jackson 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2011-11-16 14:00:17 PST
<rdar://problem/10457784>
Dean Jackson
Comment 2 2011-11-16 14:55:48 PST
Created attachment 115456 [details] Patch
Dean Jackson
Comment 3 2011-11-16 14:56:46 PST
Oops - and I'll remove the #include too.
Simon Fraser (smfr)
Comment 4 2011-11-16 17:33:31 PST
Comment on attachment 115456 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=115456&action=review > Source/WebCore/platform/graphics/filters/FilterOperation.h:271 > class DropShadowFilterOperation : public FilterOperation { Isn't there a ShadowData include that could be removed now?
Dean Jackson
Comment 5 2011-11-16 21:26:06 PST
http://trac.webkit.org/changeset/100560
Note You need to log in before you can comment on or make changes to this bug.