Bug 72540

Summary: contributors_by_fuzzy_match is super slow
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 72243    
Attachments:
Description Flags
Makes contributors_name do case insensitive comparison eric: review+

Ryosuke Niwa
Reported 2011-11-16 13:20:12 PST
contributors_by_fuzzy_match is super slow because it's calling self.contributor_by_name(string) where string is name in lowercase yet contributor_by_name doesn't do case-insensitive comparison
Attachments
Makes contributors_name do case insensitive comparison (4.45 KB, patch)
2011-11-16 13:28 PST, Ryosuke Niwa 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2011-11-16 13:28:41 PST
Created attachment 115436 [details] Makes contributors_name do case insensitive comparison
Eric Seidel (no email)
Comment 2 2011-11-16 13:31:02 PST
Comment on attachment 115436 [details] Makes contributors_name do case insensitive comparison OK. We could probably also just use @memoized and not need our own custom cache here, but this is fine.
Ryosuke Niwa
Comment 3 2011-11-16 14:24:05 PST
Committed r100505: <http://trac.webkit.org/changeset/100505>
Note You need to log in before you can comment on or make changes to this bug.