Bug 72503

Summary: Cleanup: Consolidate the many copies of Ahem in our tests
Product: WebKit Reporter: Philip Rogers <pdr>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: jamesr, kling, pdr, senorblanco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
First pass at cleaning up the many copies of Ahem
none
Second pass at cleaning up the many copies of Ahem none

Philip Rogers
Reported 2011-11-16 07:46:28 PST
There are now 5 separate copies of Ahem in our tests and we should clean this up.
Attachments
First pass at cleaning up the many copies of Ahem (89.42 KB, patch)
2011-11-16 07:50 PST, Philip Rogers 		no flags
DetailsFormatted DiffDiff
Second pass at cleaning up the many copies of Ahem (30.86 KB, patch)
2011-11-16 18:02 PST, Philip Rogers 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Philip Rogers
Comment 1 2011-11-16 07:50:53 PST
Created attachment 115378 [details] First pass at cleaning up the many copies of Ahem
Philip Rogers
Comment 2 2011-11-16 18:02:28 PST
Created attachment 115498 [details] Second pass at cleaning up the many copies of Ahem The previous patch failed to apply due to incorrect mime-types on some of the Ahem files, causing them to be treated as plaintext in the patch. I've manually edited the patch and confirmed svn-apply can apply it cleanly now.
Andreas Kling
Comment 3 2011-11-21 07:44:48 PST
Comment on attachment 115498 [details] Second pass at cleaning up the many copies of Ahem Great idea! rs=me
WebKit Review Bot
Comment 4 2011-11-21 09:55:23 PST
Comment on attachment 115498 [details] Second pass at cleaning up the many copies of Ahem Clearing flags on attachment: 115498 Committed r100930: <http://trac.webkit.org/changeset/100930>
WebKit Review Bot
Comment 5 2011-11-21 09:55:29 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.