Bug 72500

Summary: [GTK] Use a URI instead of local path to create download destination in WebKit2
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: pnormand
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch pnormand: review+

Carlos Garcia Campos
Reported 2011-11-16 06:38:43 PST
We should expect a URI instead of a local path for the destination.
Attachments
Patch (2.00 KB, patch)
2011-11-16 06:41 PST, Carlos Garcia Campos 		pnormand: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2011-11-16 06:41:56 PST
Created attachment 115371 [details] Patch
Philippe Normand
Comment 2 2011-11-16 06:47:14 PST
Comment on attachment 115371 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=115371&action=review Looks good! Maybe consider the following nit :) > Source/WebKit2/WebProcess/Downloads/soup/DownloadSoup.cpp:69 > + downloadFailed(downloadDestinationError(response, _("Cannot determine destination URI"))); What about mentioning the value of the suggestedFilename?
Martin Robinson
Comment 3 2011-11-16 08:51:20 PST
Comment on attachment 115371 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=115371&action=review >> Source/WebKit2/WebProcess/Downloads/soup/DownloadSoup.cpp:69 > > What about mentioning the value of the suggestedFilename? I think this is a good idea! _ seems to accept standard printf format parameters.
Carlos Garcia Campos
Comment 4 2011-11-16 23:59:22 PST
Committed r100569: <http://trac.webkit.org/changeset/100569>
Note You need to log in before you can comment on or make changes to this bug.