Bug 72474

Summary:

Change HashMap implementation to use the pass type and peek type from traits for the mapped value

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

Web Template Framework

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aroben, dglazkov, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

72473, 73477

Bug Blocks:

70565, 72475, 72476, 72477

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ec2-cr-linux-01	none
Patch	none
Archive of layout-test-results from ec2-cr-linux-03	none
Patch	andersca: review+

Darin Adler

Reported 2011-11-15 23:37:09 PST

To make HashMap work with OwnPtr, we need to make it use the pass type and peek type from hash traits.

Attachments
Patch (14.40 KB, patch) 2011-11-16 00:11 PST, Darin Adler	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ec2-cr-linux-01 (53.69 KB, application/zip) 2011-11-16 01:01 PST, WebKit Review Bot	no flags	Details
Patch (17.37 KB, patch) 2011-11-16 09:44 PST, Darin Adler	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ec2-cr-linux-03 (56.33 KB, application/zip) 2011-11-16 11:01 PST, WebKit Review Bot	no flags	Details
Patch (14.46 KB, patch) 2011-12-03 17:06 PST, Darin Adler	andersca: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2011-11-16 00:11:06 PST

Created attachment 115337 [details] Patch

WebKit Review Bot

Comment 2 2011-11-16 01:01:34 PST

Comment on attachment 115337 [details] Patch Attachment 115337 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10483660 New failing tests: animations/animation-controller-drt-api.html animations/3d/transform-origin-vs-functions.html accessibility/aria-checkbox-checked.html http/tests/appcache/access-via-redirect.php http/tests/appcache/auth.html animations/animation-css-rule-types.html animations/3d/matrix-transform-type-animation.html animations/animation-direction.html accessibility/aria-checkbox-text.html http/tests/appcache/cyrillic-uri.html http/tests/appcache/credential-url.html http/tests/appcache/crash-when-navigating-away-then-back.html accessibility/anonymous-render-block-in-continuation-causes-crash.html accessibility/adjacent-continuations-cause-assertion-failure.html animations/3d/change-transform-in-end-event.html animations/3d/replace-filling-transform.html animations/3d/state-at-end-event-transform.html accessibility/anchor-linked-anonymous-block-crash.html animations/animation-direction-normal.html animations/animation-add-events-in-handler.html

WebKit Review Bot

Comment 3 2011-11-16 01:01:37 PST

Created attachment 115346 [details] Archive of layout-test-results from ec2-cr-linux-01 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-01 Port: Chromium Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

Adam Roben (:aroben)

Comment 4 2011-11-16 08:31:21 PST

Comment on attachment 115337 [details] Patch What about take()? Shouldn't that return a MappedPassType?

Darin Adler

Comment 5 2011-11-16 08:35:55 PST

Comment on attachment 115337 [details] Patch Patch may be right, but we might need to have the prerequisite patches checked in. I’ll try re-uploading later.

Darin Adler

Comment 6 2011-11-16 08:36:09 PST

(In reply to comment #4) > What about take()? Shouldn't that return a MappedPassType? Yes, it should.

Darin Adler

Comment 7 2011-11-16 09:44:24 PST

Created attachment 115397 [details] Patch

WebKit Review Bot

Comment 8 2011-11-16 11:01:21 PST

Comment on attachment 115397 [details] Patch Attachment 115397 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10485841 New failing tests: animations/animation-controller-drt-api.html animations/3d/transform-origin-vs-functions.html accessibility/aria-checkbox-checked.html http/tests/appcache/access-via-redirect.php http/tests/appcache/auth.html animations/animation-css-rule-types.html animations/3d/matrix-transform-type-animation.html animations/animation-direction.html accessibility/aria-checkbox-text.html http/tests/appcache/cyrillic-uri.html http/tests/appcache/credential-url.html http/tests/appcache/crash-when-navigating-away-then-back.html accessibility/anonymous-render-block-in-continuation-causes-crash.html accessibility/adjacent-continuations-cause-assertion-failure.html animations/3d/change-transform-in-end-event.html animations/3d/replace-filling-transform.html animations/3d/state-at-end-event-transform.html accessibility/anchor-linked-anonymous-block-crash.html animations/animation-direction-normal.html animations/animation-add-events-in-handler.html

WebKit Review Bot

Comment 9 2011-11-16 11:01:24 PST

Created attachment 115409 [details] Archive of layout-test-results from ec2-cr-linux-03 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-03 Port: Chromium Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

Darin Adler

Comment 10 2011-12-03 17:06:57 PST

Created attachment 117776 [details] Patch

Darin Adler

Comment 11 2011-12-03 19:45:18 PST

Committed r101942: <http://trac.webkit.org/changeset/101942>

Note You need to log in before you can comment on or make changes to this bug.